On Wed, Jun 12, 2019 at 5:14 PM Dmitry Torokhov
[off-list ref] wrote:

On Wed, Jun 12, 2019 at 7:45 AM Jiri Kosina [off-list ref] wrote:

quoted

On Tue, 11 Jun 2019, Dmitry Torokhov wrote:

quoted

quoted

+static const char *hid_elan_i2c_ignore[] = {

If this is a copy of elan whitelist, then, if we do not want to bother
with sharing it in object form (as a elan-i2c-ids module), can we at
least move it into include/linux/input/elan-i2c-ids.h and consume from
hid-quirks.c?

Let's just not duplicate it in both objects. Why not properly export it
from hid_quirks?

Strictly speaking Elan does not depend on HID; exporting it from
quirks would mean adding this dependency. This also mean that you
can't make Elan built-in while keeping HID as a module (I think this
at least used to be config on some Chromebooks).

I also think it would me things cleaner to have the list of devices in elan_i2c.
If we put the list of devices supported by elan_i2c in a header, and
have HID read this .h file directly, there will be no runtime
dependency.

I am sure we can work something out to remove Jeffrey's fears.

Cheers,
Benjamin