Re: [PATCH] Input: alps: Drop unlikely before IS_ERR(_OR_NULL)
From: Pali Rohár <hidden>
Date: 2019-06-05 14:42:46
Also in:
lkml
On Wednesday 05 June 2019 22:24:28 Kefeng Wang wrote:
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag, so no need to do that again from its callers. Drop it.
Hi! I already reviewed this patch and rejected it, see: https://patchwork.kernel.org/patch/10817475/
quoted hunk ↗ jump to hunk
Cc: "Pali Rohár" <redacted> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-input@vger.kernel.org Signed-off-by: Kefeng Wang <redacted> --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 0a6f7ca883e7..791ef0f826c5 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c@@ -1478,7 +1478,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse, /* On V2 devices the DualPoint Stick reports bare packets */ dev = priv->dev2; dev2 = psmouse->dev; - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) { + } else if (IS_ERR_OR_NULL(priv->dev3)) { /* Register dev3 mouse if we received PS/2 packet first time */ if (!IS_ERR(priv->dev3)) psmouse_queue_work(psmouse, &priv->dev3_register_work,
-- Pali Rohár pali.rohar@gmail.com