Thread (16 messages) 16 messages, 4 authors, 2019-04-09

Re: [PATCH 2/6] MIPS: SGI-IP27: remove setup of RTC platform device

From: Thomas Bogendoerfer <hidden>
Date: 2019-04-08 18:49:06
Also in: linux-mips, linux-rtc, linux-serial, lkml, netdev

On Mon, 08 Apr 2019 10:05:28 -0700 (PDT)
David Miller [off-list ref] wrote:
From: Thomas Bogendoerfer <redacted>
Date: Mon,  8 Apr 2019 16:20:54 +0200
quoted
RTC platform device will be setup by new IOC3 MFD driver, therefore
remove it from IP27 platform code.

Signed-off-by: Thomas Bogendoerfer <redacted>
You cannot break the driver like this.

Your patch series must be fully bisectable, which means that after
this patch is applied things still must continue working properly.
I see your point and the ethernet driver itself will work properly, but of
course IP27 will be working again after applying the whole series. One
way I can see to solve this to also add the addition of the serial driver
into it. Then we are on par with the current driver. Does this solve your
concern ?

Thomas.

-- 
SUSE Linux GmbH
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help