Thread (28 messages) 28 messages, 6 authors, 2019-04-08

Re: [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver.

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2019-03-27 19:22:18
Also in: lkml

On Wed, Mar 27, 2019 at 07:45:26PM +0100, Greg Kroah-Hartman wrote:
On Wed, Mar 27, 2019 at 11:35:30AM +0200, Andy Shevchenko wrote:
quoted
On Tue, Mar 26, 2019 at 06:48:07PM -0700, Ronald Tschalär wrote:
quoted
The keyboard and trackpad on recent MacBook's (since 8,1) and
MacBookPro's (13,* and 14,*) are attached to an SPI controller instead
of USB, as previously. The higher level protocol is not publicly
documented and hence has been reverse engineered. As a consequence there
are still a number of unknown fields and commands. However, the known
parts have been working well and received extensive testing and use.

In order for this driver to work, the proper SPI drivers need to be
loaded too; for MB8,1 these are spi_pxa2xx_platform and spi_pxa2xx_pci;
for all others they are spi_pxa2xx_platform and intel_lpss_pci. For this
reason enabling this driver in the config implies enabling the above
drivers.
quoted
+// SPDX-License-Identifier: GPL-2.0
According to last changes this should be GPL-2.0-only
What "last changes"?  "GPL-2.0" is a totally valid SPDX identifier for
the kernel.  Don't buy into the "-only" prefix crud that the newer SPDX
version adopted for crazy reasons.  The in-kernel documentation lists
the valid identifiers and the version of SPDX we are currently using.
Thanks for this clarification.

// offtopic

Bartosz, so, it seems my first mail has been a correct one: in-kernel
documentation clarifies things for kernel.

// offtopic

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help