On Mon, Feb 18, 2019 at 03:21:10PM +0100, Rodrigo Rivas Costa wrote:

On Sun, Feb 17, 2019 at 09:42:52PM -0300, Marcos Paulo de Souza wrote:

quoted

-	if (!wait_for_completion_timeout(&request->done, 30 * HZ)) {
+	if (!wait_for_completion_interruptible_timeout(&request->done,
+							30 * HZ)) {
 		retval = -ETIMEDOUT;
 		goto out;
 	}

Now this function can succeed or fail because of ETIMEDOUT or an
interrupt. I think you should return -EINTR or maybe -ESYSRESTART if
interrupted.

Rodrigo, you are right. Marcos, could you please send updated patch that
returns different error code for timeout vs interrupt condition?

I dropped the patch for now.

Thanks.

-- 
Dmitry