Re: [PATCH] Input: synaptics_i2c - remove redundant spinlock
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2019-02-17 05:30:05
Also in:
lkml
Hi Sven, On Mon, Feb 11, 2019 at 08:34:42PM -0500, thesven73@gmail.com wrote:
quoted hunk ↗ jump to hunk
@@ -372,13 +371,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch) static void synaptics_i2c_reschedule_work(struct synaptics_i2c *touch, unsigned long delay) { - unsigned long flags; - - spin_lock_irqsave(&touch->lock, flags); - mod_delayed_work(system_wq, &touch->dwork, delay); - - spin_unlock_irqrestore(&touch->lock, flags); }
This makes synaptics_i2c_reschedule_work() a useless wrapper for mod_delayed_work(). Can we get rid of it? Thanks. -- Dmitry