Thread (2 messages) 2 messages, 2 authors, 2019-02-17
STALE2661d

[PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()

From: Martin Kepplinger <martink@posteo.de>
Date: 2019-02-13 11:20:19
Also in: lkml
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

gpiod_set_value_cansleep() needs it's declaration in the corresponding
header. This fixes build errors like

   drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
quoted
drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
   function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
   [-Werror=implicit-function-declaration]
      gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
      ^~~~~~~~~~~~~~~~~~~~~~~~
      gpio_set_value_cansleep

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---

 drivers/input/touchscreen/st1232.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c
index 1fbc0847416b..f4b7a4f1c366 100644
--- a/drivers/input/touchscreen/st1232.c
+++ b/drivers/input/touchscreen/st1232.c
@@ -18,6 +18,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/pm_qos.h>
 #include <linux/slab.h>
 #include <linux/types.h>
-- 
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help