wt., 12 lut 2019 o 13:07 Pavel Machek [off-list ref] napisał(a):

Hi!

quoted

+#define MAX77650_CHARGER_ENABLED             BIT(0)
+#define MAX77650_CHARGER_DISABLED            0x00
+#define MAX77650_CHARGER_CHG_EN_MASK         BIT(0)
+
+#define MAX77650_CHARGER_CHG_DTLS_MASK               GENMASK(7, 4)
+#define MAX77650_CHARGER_CHG_DTLS_BITS(_reg) \
+             (((_reg) & MAX77650_CHARGER_CHG_DTLS_MASK) >> 4)
+
+#define MAX77650_CHARGER_CHG_OFF             0x00
+#define MAX77650_CHARGER_CHG_PREQ            0x01
+#define MAX77650_CHARGER_CHG_ON_CURR         0x02
+#define MAX77650_CHARGER_CHG_ON_JCURR                0x03
+#define MAX77650_CHARGER_CHG_ON_VOLT         0x04
+#define MAX77650_CHARGER_CHG_ON_JVOLT                0x05
+#define MAX77650_CHARGER_CHG_ON_TOPOFF               0x06
+#define MAX77650_CHARGER_CHG_ON_JTOPOFF              0x07
+#define MAX77650_CHARGER_CHG_DONE            0x08
+#define MAX77650_CHARGER_CHG_JDONE           0x09
+#define MAX77650_CHARGER_CHG_SUSP_PF         0x0a
+#define MAX77650_CHARGER_CHG_SUSP_FCF                0x0b
+#define MAX77650_CHARGER_CHG_SUSP_BTF                0x0c

These are really bad define names. We are in charger driver, so
MAX77650_CHARGER_ really should be shortened/ommited. OTOH
more space should be given to "CHG_SUSP_BTF" as it is impossible to decipher.

I disagree about the prefix bit. I prefer to use common prefixes for
all symbols in a driver. I would rather add comments to every
definition here.

Bart

quoted

+#define MAX77650_CHARGER_CHGIN_DTLS_MASK     GENMASK(3, 2)
+#define MAX77650_CHARGER_CHGIN_DTLS_BITS(_reg) \
+             (((_reg) & MAX77650_CHARGER_CHGIN_DTLS_MASK) >> 2)
+
+#define MAX77650_CHARGER_CHGIN_UVL           0x00
+#define MAX77650_CHARGER_CHGIN_OVL           0x01
+#define MAX77650_CHARGER_CHGIN_OKAY          0x11

UVL -> UNDERVOLTAGE, OVL -> OVERVOLTAGE?


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html