Re: Another HID problem this merge window..

Hi,

On Sat, Oct 27, 2018 at 11:45 PM Jiri Kosina [off-list ref] wrote:

On Sat, 27 Oct 2018, Linus Torvalds wrote:

quoted

I wonder if there is some truly old historical legacy there, ie the old
PC keyboard support would have been configurable out only for expert
users to avoid errors, and maybe the HID Kconfig file started getting
ideas from that...

This really goes waaay back to times when we extracted all the quirks from
the generic driver (which became unmaintainable exactly because quirks
being sprinkled left and right) into specialized drivers, but didn't want
to cause too many user surprises that all of a sudden their configuration
regressed when it comes to hardware support.

We've had exactly this discussion multiple times before, see for example

        https://lkml.org/lkml/2010/5/20/227

So I guess there is no need for replaying it, I think we're in complete
agreement.

On the things I have on my plate, I'll try to remove all of the tiny
HID drivers that does nothing but some small remapping. This will
probably need help from userspace ("firmware" or bpf loading), and I
have not settled my plans yet.
I also think we should probably clean up the Kconfig now that
hid-generic can unbind itself if there is a special driver coming in.
And that means that we should probably start removing the blacklist of
devices that have special modules, to let them be taken by hid-generic
on boot until their driver is loaded.

That being said, benff Kconfig setting definitely escaped attention. That
should never ever have been set to default y, I take blame for not
noticing that while applying the patch.

Not sure I have actually reviewed this one (I don't think so), but
I'll keep this in my head for next drivers.

Cheers,
Benjamin

Thanks,

--
Jiri Kosina
SUSE Labs