Thread (2 messages) 2 messages, 2 authors, 2018-10-09

Re: [PATCH] HID: google: drop superfluous const before SIMPLE_DEV_PM_OPS()

flat view

From: Dmitry Torokhov <hidden>
Date: 2018-10-09 17:34:44
Also in: lkml

On Tue, Oct 9, 2018 at 1:48 AM Jiri Kosina [off-list ref] wrote:
From: Jiri Kosina <redacted>

SIMPLE_DEV_PM_OPS() already implies const for the type; drop the extra
modifier.

Fixes: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c ("HID: google: add support tablet mode switch for Whiskers")
Signed-off-by: Jiri Kosina <redacted>
FWIW

Acked-by: Dmitry Torokhov <redacted>
quoted hunk ↗ jump to hunk
---

In hid.git#for-4.20/google

 drivers/hid/hid-google-hammer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index de3e7d055ca4..ee5e0bdcf078 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -161,7 +161,7 @@ static __maybe_unused int cbas_ec_resume(struct device *dev)
        return 0;
 }

-static const SIMPLE_DEV_PM_OPS(cbas_ec_pm_ops, NULL, cbas_ec_resume);
+static SIMPLE_DEV_PM_OPS(cbas_ec_pm_ops, NULL, cbas_ec_resume);

 static void cbas_ec_set_input(struct input_dev *input)
 {

--
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help