Thread (12 messages) 12 messages, 2 authors, 2018-12-18

Re: [PATCH 6/7] HID: logitech-hidpp: support the G700 over wireless

From: Harry Cutts <hidden>
Date: 2018-09-07 17:33:33
Also in: lkml 

Hi Benjamin,

On Fri, 7 Sep 2018 at 03:35, Benjamin Tissoires
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
The G700 is using a non unifying receiver, so it's easy to add its support
in hid-logitech-hidpp now.
[snip]
@@ -3671,6 +3671,9 @@ static const struct hid_device_id hidpp_devices[] = {
        { /* Solar Keyboard Logitech K750 */
          LDJ_DEVICE(0x4002),
          .driver_data = HIDPP_QUIRK_CLASS_K750 },
+       { /* G700 over Wireless */
+         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G700_RECEIVER),
+         .driver_data = HIDPP_QUIRK_RECEIVER | HIDPP_QUIRK_UNIFYING },
As someone who's new to the codebase, it seems rather confusing to me
that HIDPP_QUIRK_UNIFYING would be present here for a device that
doesn't use a Unifying receiver. Am I misunderstanding, or should we
consider renaming the quirk or adding some clarifying comment?
(Similarly for the G900 in the next patch.)

        { LDJ_DEVICE(HID_ANY_ID) },

--
2.14.3
Thanks,

Harry Cutts
Chrome OS Touch/Input team
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help