Re: [PATCH] input: olpc_apsp: remove unused pointer 'np'
flat view
From: Andi Shyti <hidden>
Date: 2018-08-28 20:02:00
Also in:
kernel-janitors, lkml
Hi Colin, On Tue, Aug 28, 2018 at 03:56:48PM +0100, Colin King wrote:
From: Colin Ian King <redacted> Pointer 'nb' is being assigned but is never used hence it is
'np' here. Other than that, Reviewed-by: Andi Shyti <redacted> Andi
quoted hunk ↗ jump to hunk
redundant and can be removed. Cleans up clang warning: warning: variable 'np' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <redacted> --- drivers/input/serio/olpc_apsp.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/input/serio/olpc_apsp.c b/drivers/input/serio/olpc_apsp.c index 8e9a4209fcad..8bd8ed25946f 100644 --- a/drivers/input/serio/olpc_apsp.c +++ b/drivers/input/serio/olpc_apsp.c@@ -172,7 +172,6 @@ static int olpc_apsp_probe(struct platform_device *pdev) struct serio *kb_serio, *pad_serio; struct olpc_apsp *priv; struct resource *res; - struct device_node *np; unsigned long l; int error;@@ -180,7 +179,6 @@ static int olpc_apsp_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; - np = pdev->dev.of_node; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); priv->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(priv->base)) {-- 2.17.1