Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public

On 07/03/18 at 11:57pm, Andy Shevchenko wrote:

On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He [off-list ref] wrote:

quoted

On 06/12/18 at 05:24pm, Andy Shevchenko wrote:

quoted

On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
[off-list ref] wrote:

quoted

quoted

quoted

I briefly looked at the code and error codes we have, so, my proposal
is one of the following

quoted

 - use -ECANCELED (not the best choice for first occurrence here,
though I can't find better)

Actually -ENOTSUPP might suit the first case (although the actual
would be something like -EOVERLAP, which we don't have)

Sorry for late reply, and many thanks for your great suggestion.

quoted

I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED
for the 2nd one.

I have no strong opinion, but I like (slightly better) this approach ^^^

Done, post v6 in this way, many thanks.

quoted

Or define an enum as you suggested inside the function
or in header file.

quoted

Or use -EBUSY for the first case because existing resource is
overlapping but not fully contained by 'res'; and -EINVAL for
the 2nd case since didn't find any one resources which is contained by
'res', means we passed in a invalid resource.

All is fine to me, I can repost with each of them.

quoted

quoted

quoted

 - use positive integers (or enum), like
  #define RES_REPARENTED 0
  #define RES_OVERLAPPED 1
  #define RES_NOCONFLICT 2

-- 
With Best Regards,
Andy Shevchenko