Re: [PATCH] HID: roccat: Mark expected switch fall-through
From: Jiri Kosina <jikos@kernel.org>
Date: 2018-07-17 13:53:32
Also in:
lkml
On Mon, 2 Jul 2018, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <redacted> --- drivers/hid/hid-roccat-kone.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c index bf4675a..c4dd616 100644 --- a/drivers/hid/hid-roccat-kone.c +++ b/drivers/hid/hid-roccat-kone.c@@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone, case kone_mouse_event_switch_profile: kone->actual_dpi = kone->profiles[event->value - 1]. startup_dpi; + /* fall through */ case kone_mouse_event_osd_profile: kone->actual_profile = event->value; break;
I *think* the fall-through is correct thing to do here, but I'd like to get explicit Ack from Stefan. Stefan, please? -- Jiri Kosina SUSE Labs