Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks
From: Benjamin Tissoires <hidden>
Date: 2018-07-03 07:53:26
Also in:
lkml
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas <redacted> 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 45968f7970f87775fa..a793076139d7d0db9b 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c@@ -242,11 +242,12 @@ static struct mt_class mt_classes[] = { .quirks = MT_QUIRK_ALWAYS_VALID | MT_QUIRK_IGNORE_DUPLICATES | MT_QUIRK_HOVERING | MT_QUIRK_CONTACT_CNT_ACCURATE | MT_QUIRK_STICKY_FINGERS | - MT_QUIRK_WIN8_PTP_BUTTONS }, + MT_QUIRK_WIN8_PTP_BUTTONS | + MT_QUIRK_NOT_SEEN_MEANS_UP },
NACK on this. If the Surface has a buggy firmware, we should handle it as a special case, not as a common failure. Also, I am not sure this quirk is compatible with Win 8 specification. Last, we now have a timeout for unreleased touches, so I really don't think you need that in recent kernels. Cheers, Benjamin
{ .name = MT_CLS_EXPORT_ALL_INPUTS,
.quirks = MT_QUIRK_ALWAYS_VALID |
MT_QUIRK_CONTACT_CNT_ACCURATE,
.export_all_inputs = true },
{ .name = MT_CLS_WIN_8_DUAL,
--
2.18.0