Hi Joe,

On 06/06/18 17:42, Joe Perches wrote:

On Wed, 2018-06-06 at 17:08 +0200, Enric Balletbo i Serra wrote:

quoted

Dear all,

This patchset is just to adopt the SPDX license identifier for all
ChromeOS Embedded Controller related drivers.

This bit is fine,

quoted

 The patches touches
different subsystems but every patch can be picked from their respective
maintainer independently.

This third version takes the license note as the valid license (I did
the contrary in the second version) so apart from add the SPDX tags it
also introduces new patches to match the license.

But why change any MODULE_LICENSE text?

Because in some cases there is a mismatch between the license note and the
MODULE_LICENSE text.

According to the documentation setting MODULE_LICENSE("GPL") means GNU Public
License v2 or later [1], in the cases where the license note tells explicitly
that is GPL v2 only I think that the MODULE_LICENSE should match and be changed
to "GPL v2".

[1] https://elixir.bootlin.com/linux/v4.17/source/include/linux/module.h#L172

There are uses of MODULE_LICENSE("GPL") where
the SPDX license identifier is some GPL variant

Right, but I suppose in such cases is wrong and should be changed too?

For instance:
$ git grep -P --name-only
'MODULE_LICENSE\s*\("GPL"\s*\)\s*;'| \
  xargs grep "SPDX-License-
Identifier:" | \
  cut -f3- -d: | \
  sed -r 's@\s*\*/\s*$@@' | \
  sort |
uniq -c | sort -rn
    551  GPL-2.0+
    281  GPL-2.0
     13  GPL-1.0+
    
  9  GPL-2.0-only
      2  GPL-2.0 OR MIT
      1  (GPL-2.0 OR MPL-1.1)
   
   1  (GPL-2.0+ OR BSD-3-Clause)
      1  (GPL-2.0 OR BSD-3-Clause)

And if you were to do this, please do it tree-wide,
and ideally via a script