Re: [PATCH v2 1/3] input: touchscreen: edt-ft5x06: don't make device a wakeup source by default
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2018-05-24 23:17:32
Also in:
linux-arm-kernel, linux-devicetree
On Wed, May 23, 2018 at 09:45:05AM -0500, Rob Herring wrote:
On Wed, May 23, 2018 at 3:27 AM, Daniel Mack [off-list ref] wrote:quoted
On Tuesday, May 22, 2018 07:54 PM, Rob Herring wrote:quoted
On Thu, May 17, 2018 at 11:05:50AM +0200, Daniel Mack wrote:quoted
Allow configuring the device as wakeup source through device properties, as not all platforms want to wake up on touch screen activity. The I2C core automatically reads the "wakeup-source" DT property to configure a device's wakeup capability, and board supports files can set I2C_CLIENT_WAKE in the flags.This will break wake-up on working systems. Looks like mostly i.MX, but there's one AM437x board. If that board doesn't care, then it is up to Shawn.I added the property to the dts files, but as Dmitry pointed out, I missed some. Sorry for that.Just adding the property to dts files doesn't fix the compatibility problem. If a user uses an existing dtb (before this change) with a new kernel (after this change), then wakeup will stop working.
Is this a practical problem though? Do we know of any products with this touch panel that use DTS not distributed with the kernel? -- Dmitry