Re: [PATCH] HID: steam: select CONFIG_POWER_SUPPLY
From: Benjamin Tissoires <hidden>
Date: 2018-05-25 16:40:29
Also in:
lkml
On Fri, May 25, 2018 at 5:30 PM, Arnd Bergmann [off-list ref] wrote:
Using the power supply APIs requires selecting the appropriate
Kconfig symbol, otherwise we get this build failure:
drivers/hid/hid-steam.o: In function `steam_unregister':
hid-steam.c:(.text+0x1cc): undefined reference to `power_supply_unregister'
drivers/hid/hid-steam.o: In function `steam_battery_get_property':
hid-steam.c:(.text+0x2d2): undefined reference to `power_supply_get_drvdata'
drivers/hid/hid-steam.o: In function `steam_raw_event':
hid-steam.c:(.text+0xcba): undefined reference to `power_supply_changed'
drivers/hid/hid-steam.o: In function `steam_register':
hid-steam.c:(.text+0x13e3): undefined reference to `power_supply_register'
hid-steam.c:(.text+0x13fe): undefined reference to `power_supply_powers'
Fixes: f82719790751 ("HID: steam: add battery device.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Looks good: Reviewed-by: Benjamin Tissoires <redacted>
quoted hunk ↗ jump to hunk
--- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 8a865e3ccea6..a49a10437c40 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig@@ -848,6 +848,7 @@ config HID_SPEEDLINK config HID_STEAM tristate "Steam Controller support" depends on HID + select POWER_SUPPLY ---help--- Say Y here if you have a Steam Controller if you want to use it without running the Steam Client. It supports both the wired and --2.9.0