Re: [PATCH] input: fix coding style issues in input.c
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2018-05-10 00:33:18
Also in:
lkml
Hi NIck, On Wed, May 09, 2018 at 05:07:14PM +0300, Nick Simonov wrote:
quoted hunk ↗ jump to hunk
This is a patch to the input.c file that fixes up warning found by checkpatch.pl tool Signed-off-by: Nick Simonov <redacted> --- drivers/input/input.c | 52 ++++++++++++++++++++++++++++++++------------------- 1 file changed, 33 insertions(+), 19 deletions(-)diff --git a/drivers/input/input.c b/drivers/input/input.c index 9785546..e18fdae 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * The input core *@@ -252,7 +253,8 @@ static int input_handle_abs_event(struct input_dev *dev, } /* Flush pending "slot" event */ - if (is_mt_event && mt && mt->slot != input_abs_get_val(dev, ABS_MT_SLOT)) { + if (is_mt_event && mt && mt->slot != + input_abs_get_val(dev, ABS_MT_SLOT)) { input_abs_set_val(dev, ABS_MT_SLOT, mt->slot);
So now it is not immediately clear what is part of condition and what is part of body. I am sorry to say, but with most of these changes the cure is worse than the disease. If you were fixing the code and adjusted the affected lines so they are under 80 columns limit that would be one thing, but just reformatting for the sake of it is not really helpful. Thanks. -- Dmitry