Re: [PATCHv2] Input: atmel_mxt_ts - fix reset-gpio for level based irqs
From: Sebastian Reichel <hidden>
Date: 2018-05-09 14:40:37
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Sebastian Reichel <hidden>
Date: 2018-05-09 14:40:37
Also in:
lkml
Hi, On Wed, May 09, 2018 at 04:25:45PM +0200, Pavel Machek wrote:
On Mon 2018-04-23 13:58:44, Sebastian Reichel wrote:quoted
The current reset-gpio support triggers an interrupt storm on platforms using the maxtouch with level based interrupt. The Motorola Droid 4, which I used for some of the tests is not affected, since it uses a edge based interrupt. This change avoids the interrupt storm by enabling the device while its interrupt is disabled. Afterwards we wait 100ms. This is important for two reasons: The device is unresponsive for some time (~22ms for mxt224E) and the CHG (interrupt) line is not working properly for 100ms. We don't need to wait for any following interrupts, since the following mxt_initialize() checks for bootloader mode anyways. This fixes a boot issue on GE PPD (watchdog kills device due to interrupt storm) and does not cause regression on Motorola Droid 4.Out of curiosity, what is "GE PPD"?
PPD is a product from GE Healthcare to monitor vital biometric signals: arch/arm/boot/dts/imx53-ppd.dts
quoted
Fixes: f657b00df22e ("Input: atmel_mxt_ts - add support for reset line") Signed-off-by: Sebastian Reichel <redacted>Reviewed-by: Pavel Machek <redacted>
Thanks, -- Sebastian