Thread (9 messages) 9 messages, 5 authors, 2018-05-02

Re: [PATCH v2] Input: atmel_mxt_ts - add missing compatible strings to OF device table

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2018-05-01 22:49:27
Also in: linux-arm-kernel, linux-devicetree, lkml

On Tue, May 01, 2018 at 04:33:07PM -0500, Rob Herring wrote:
On Tue, May 1, 2018 at 3:57 PM, Dmitry Torokhov
[off-list ref] wrote:
quoted
From: Javier Martinez Canillas <javierm@redhat.com>

Commit af503716ac14 ("i2c: core: report OF style module alias for devices
registered via OF") fixed how the I2C core reports the module alias when
devices are registered via OF.

But the atmel_mxt_ts driver only has an "atmel,maxtouch" compatible in its
OF device ID table, so if a Device Tree is using a different one, autoload
won't be working for the module (the matching works because the I2C device
ID table is used as a fallback).

So add compatible strings for each of the entries in the I2C device table.

Fixes: af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF")
Reported-by: Enric Balletbo i Serra <redacted>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Enric Balletbo i Serra <redacted>
[dtor: document which compatibles are deprecated and should not be used]
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 .../devicetree/bindings/input/atmel,maxtouch.txt   |    7 +++++++
 drivers/input/touchscreen/atmel_mxt_ts.c           |    5 +++++
 2 files changed, 12 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>

Someone is going to make the dts updates, right?
I sent out 2 patches...

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help