Thread (29 messages) 29 messages, 3 authors, 2018-03-20

Re: [PATCH 14/14] Input: atmel_mxt_ts - remove platform data support

From: Nick Dyer <nick@shmanahar.org>
Date: 2018-03-16 20:47:54
Also in: lkml

On Thu, Mar 15, 2018 at 05:06:14PM -0700, Dmitry Torokhov wrote:
On Wed, Mar 14, 2018 at 08:59:38PM +0000, Nick Dyer wrote:
quoted
On Mon, Mar 12, 2018 at 12:09:07PM -0700, Dmitry Torokhov wrote:
quoted
-	/*
-	 * Ignore ACPI devices representing bootloader mode.
-	 *
-	 * This is a bit of a hack: Google Chromebook BIOS creates ACPI
-	 * devices for both application and bootloader modes, but we are
-	 * interested in application mode only (if device is in bootloader
-	 * mode we'll end up switching into application anyway). So far
-	 * application mode addresses were all above 0x40, so we'll use it
-	 * as a threshold.
-	 */
-	if (client->addr < 0x40)
-		return -ENXIO;
Could you use 0x4a, since that's the lowest application mode address,
same in the other place.
OK, this is existing code though, so I'll make a separate patch.
Ah, I see now. In which case it's no big deal.

Acked-by: Nick Dyer <nick@shmanahar.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help