Hi Brain,

Thanks for your reply.

On 03/02/2018 10:32 AM, Brian Norris wrote:

quoted

quoted

quoted

quoted

What about the 'else' case? Shouldn't we try to handle that?

i think the else case is for irq key, which would generate down and up
events in one irq, so it would use the same trigger type for all these 3
cases.

Not necessarily. It uses whatever trigger was provided in
platform/DT/etc. data. You could retrieve that with
irq_get_trigger_type() and try to interpret that. Or you could just
outlaw using that combination (e.g., in the binding documentation).

i think for the IRQ button case the assert/deassert/any are using the 
same irq trigger type, so it should be ok to leave the wakeup trigger 
type to be 0(not reconfigure the trigger type)...

i've made a v3 to add a comment about that, but forgot to send it :(

Brian