Thread (8 messages) 8 messages, 4 authors, 2018-03-12

Re: [PATCH v5 1/3] Input: gpio-keys - add support for wakeup event action

From: Rob Herring <robh@kernel.org>
Date: 2018-03-09 23:27:21
Also in: linux-devicetree, lkml

On Thu, Mar 08, 2018 at 03:32:11PM +0800, Jeffy Chen wrote:
Add support for specifying event actions to trigger wakeup when using
the gpio-keys input device as a wakeup source.

This would allow the device to configure when to wakeup the system. For
example a gpio-keys input device for pen insert, may only want to wakeup
the system when ejecting the pen.

Suggested-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Jeffy Chen <redacted>
---

Changes in v5:
Remove unneeded irq_wake flag as Andy suggested.

Changes in v4:
Add dt-binding gpio-keys.h, stop saving irq trigger type, add enable/disable wakeup helpers as Dmitry suggested.

Changes in v3:
Adding more comments as Brian suggested.

Changes in v2:
Specify wakeup event action instead of irq trigger type as Brian
suggested.

 drivers/input/keyboard/gpio_keys.c    | 63 +++++++++++++++++++++++++++++++++--
 include/dt-bindings/input/gpio-keys.h | 13 ++++++++
This file should be in the binding patch.
 include/linux/gpio_keys.h             |  2 ++
 3 files changed, 75 insertions(+), 3 deletions(-)
 create mode 100644 include/dt-bindings/input/gpio-keys.h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help