Re: [PATCH 5/5] add default control values as module parameters
From: Hans Verkuil <hidden>
Date: 2018-02-05 14:56:16
Also in:
linux-media
On 02/05/2018 03:29 PM, Florian Echtler wrote:
Signed-off-by: Florian Echtler <redacted>
Please add a change log when you make a patch. I for one would like to know why this has to be supplied as a module option. Some documentation in the code would be helpful as well (e.g. I have no idea what a 'vsvideo' is). Regards, Hans
quoted hunk ↗ jump to hunk
--- drivers/input/touchscreen/sur40.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index c4b7cf1..d612f3f 100644 --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c@@ -173,6 +173,14 @@ int sur40_v4l2_contrast = SUR40_CONTRAST_DEF; /* blacklevel */ int sur40_v4l2_gain = SUR40_GAIN_DEF; /* gain */ int sur40_v4l2_backlight = 1; /* preprocessor */ +/* module parameters */ +static uint irlevel = SUR40_BRIGHTNESS_DEF; +module_param(irlevel, uint, 0644); +MODULE_PARM_DESC(irlevel, "set default irlevel"); +static uint vsvideo = SUR40_VSVIDEO_DEF; +module_param(vsvideo, uint, 0644); +MODULE_PARM_DESC(vsvideo, "set default vsvideo"); + static const struct v4l2_pix_format sur40_pix_format[] = { { .pixelformat = V4L2_TCH_FMT_TU08,@@ -372,6 +380,11 @@ static void sur40_open(struct input_polled_dev *polldev) dev_dbg(sur40->dev, "open\n"); sur40_init(sur40); + + /* set default values */ + sur40_set_irlevel(sur40, irlevel); + sur40_set_vsvideo(sur40, vsvideo); + sur40_set_preprocessor(sur40, SUR40_BACKLIGHT_DEF); } /* Disable device, polling has stopped. */