Re: Software evolution around “checkpatch.pl”?

From
Joe Perches <hidden>
Date
2018-02-10 17:43:04
Also in
kernel-janitors, linux-iio, lkml
Reply to
Jonathan Cameron, 2018-02-10
On Sat, 2018-02-10 at 15:57 +0000, Jonathan Cameron wrote:
On Sat, 10 Feb 2018 06:59:43 -0800
Joe Perches [off-list ref] wrote:
quoted
On Sat, 2018-02-10 at 14:53 +0000, Jonathan Cameron wrote:
quoted
While it would be great to improve checkpatches false
positive rate, it's very nature as a string matcher makes
this hard.  
true.

what are the false positives you see?
This particular case is only 'sort of' a false positive
in the warning that a message printed on a memory allocation
failure 'may' not add any information over the generic case.
Right.  So it's not a 'false positive' at all.
Are there any actual 'false positives' you know of?
Very hard to judge on whether it is useful to know more than
an allocation failed somewhere or not.

Message makes this clear:
quoted
“WARNING: Possible unnecessary 'out of memory' message”
(from the script “checkpatch.pl”)  
We also have the balance between any changes to existing code
adding 'some' maintenance overhead vs changing this stuff
in a new driver - which is what checkpatch is really intended
for.
There's almost zero maintenance overhead here.
The time it takes for the back and forth
replies is likely larger.
So I think checkpatch is striking the right balance here in
how it warns.  Obviously if it could assess the text
and come to an informed decision that would be great but
we are some way from that ;)
The 'informed' bit is difficult as it is mostly
a political problem.

This particular message really is unnecessary as
the generic dump_stack on any normal allocation
(ie: without __GFP_WARN) already emits location
specific information.

Removing these messages can help make the kernel
image smaller and thereby help make these OOM
messages a tiny bit less likely.

I just wish Markus would improve his consistently
terrible commit messages that just restate the
action being done and detail _why_ a particular
thing _should_ be done.

His acceptance rate would improve as many of these
back and forth replies for what trivialities he
posts as patches would be minimized.
Thread (10 messages) 10 messages, 4 authors, last reply 2018-02-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help