[PATCH 1/6] hid-prodikeys: Delete two error messages for a failed memory allocation in pk_probe()
flat view
STALE3174d
From: SF Markus Elfring <hidden>
Date: 2018-02-03 17:38:05
Also in:
kernel-janitors, lkml
Subsystem:
hid core layer, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds
From: Markus Elfring <redacted> Date: Sat, 3 Feb 2018 14:36:20 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted> --- drivers/hid/hid-prodikeys.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 87eda34ea2f8..9cad4973a67b 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c@@ -802,15 +802,12 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) pk = kzalloc(sizeof(*pk), GFP_KERNEL); - if (pk == NULL) { - hid_err(hdev, "can't alloc descriptor\n"); + if (!pk) return -ENOMEM; - } pk->hdev = hdev; pm = kzalloc(sizeof(*pm), GFP_KERNEL); if (pm == NULL) { - hid_err(hdev, "can't alloc descriptor\n"); ret = -ENOMEM; goto err_free_pk; }
--
2.16.1