Hello Lothar,

Le Tue, 23 Jan 2018 09:04:14 +0100,
Lothar Waßmann [off-list ref] a écrit :

Hi,

On Mon, 22 Jan 2018 09:42:08 -0800 Dmitry Torokhov wrote:

quoted

Hi Mylène,

On Thu, Dec 28, 2017 at 8:33 AM, Mylène Josserand
[off-list ref] wrote:  

quoted

Add the support of regulator to use it as VCC source.

Signed-off-by: Mylène Josserand <redacted>
---
 .../bindings/input/touchscreen/edt-ft5x06.txt      |  1 +
 drivers/input/touchscreen/edt-ft5x06.c             | 33 ++++++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
index 025cf8c9324a..48e975b9c1aa 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt

@@ -30,6 +30,7 @@ Required properties:
 Optional properties:
  - reset-gpios: GPIO specification for the RESET input
  - wake-gpios:  GPIO specification for the WAKE input
+ - vcc-supply:  Regulator that supplies the touchscreen

  - pinctrl-names: should be "default"
  - pinctrl-0:   a phandle pointing to the pin settings for the

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index c53a3d7239e7..5ee14a25a382 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c

@@ -39,6 +39,7 @@
 #include <linux/input/mt.h>
 #include <linux/input/touchscreen.h>
 #include <linux/of_device.h>
+#include <linux/regulator/consumer.h>

 #define WORK_REGISTER_THRESHOLD                0x00
 #define WORK_REGISTER_REPORT_RATE      0x08

@@ -91,6 +92,7 @@ struct edt_ft5x06_ts_data {
        struct touchscreen_properties prop;
        u16 num_x;
        u16 num_y;
+       struct regulator *vcc;

        struct gpio_desc *reset_gpio;
        struct gpio_desc *wake_gpio;

@@ -993,6 +995,23 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,

        tsdata->max_support_points = chip_data->max_support_points;

+       tsdata->vcc = devm_regulator_get(&client->dev, "vcc");
+       if (IS_ERR(tsdata->vcc)) {
+               error = PTR_ERR(tsdata->vcc);
+               dev_err(&client->dev, "failed to request regulator: %d\n",
+                       error);  

I would check for -EPROBE_DEFER here and omit the error message in this
case.


Lothar Waßmann

Sure, I will add this case, thank you for the review.

Best regards,

-- 
Mylène Josserand, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com