Re: [PATCH 2/2] Input: sur40: Improve a size determination in sur40_probe()
flat view
From: Martin Kepplinger <martink@posteo.de>
Date: 2018-01-22 07:02:57
Also in:
kernel-janitors, lkml
On 2018-01-20 22:30, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Sat, 20 Jan 2018 22:16:14 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <redacted>
Acked-by: Martin Kepplinger <martink@posteo.de>
quoted hunk ↗ jump to hunk
--- drivers/input/touchscreen/sur40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index c7a0a92b2044..946e1a0328b4 100644 --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c@@ -550,7 +550,7 @@ static int sur40_probe(struct usb_interface *interface, return -ENODEV; /* Allocate memory for our device state and initialize it. */ - sur40 = kzalloc(sizeof(struct sur40_state), GFP_KERNEL); + sur40 = kzalloc(sizeof(*sur40), GFP_KERNEL); if (!sur40) return -ENOMEM;