Thread (6 messages) 6 messages, 4 authors, 2018-01-23

Re: [PATCH v1] HID: sony: Print reversed MAC address via %pMR

From: "Colenbrander, Roelof" <Roderick.Colenbrander@sony.com>
Date: 2017-12-13 02:22:20

On 12/11/2017 05:07 AM, Andy Shevchenko wrote:
quoted hunk ↗ jump to hunk
Reversed MAC addresses can be printed directly using %pMR specifier.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
  drivers/hid/hid-sony.c | 10 ++--------
  1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index b9dc3ac4d4aa..138fd44d3c91 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2399,10 +2399,7 @@ static int sony_check_add(struct sony_sc *sc)
  		memcpy(sc->mac_address, &buf[1], sizeof(sc->mac_address));
  
  		snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
-			"%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx",
-			sc->mac_address[5], sc->mac_address[4],
-			sc->mac_address[3], sc->mac_address[2],
-			sc->mac_address[1], sc->mac_address[0]);
+			 "%pMR", sc->mac_address);
  	} else if ((sc->quirks & SIXAXIS_CONTROLLER_USB) ||
  			(sc->quirks & NAVIGATION_CONTROLLER_USB)) {
  		buf = kmalloc(SIXAXIS_REPORT_0xF2_SIZE, GFP_KERNEL);
@@ -2432,10 +2429,7 @@ static int sony_check_add(struct sony_sc *sc)
  			sc->mac_address[5-n] = buf[4+n];
  
  		snprintf(sc->hdev->uniq, sizeof(sc->hdev->uniq),
-			"%02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx",
-			sc->mac_address[5], sc->mac_address[4],
-			sc->mac_address[3], sc->mac_address[2],
-			sc->mac_address[1], sc->mac_address[0]);
+			 "%pMR", sc->mac_address);
  	} else {
  		return 0;
  	}
Looks good and in a quick test seems to function.

Acked-by: Roderick Colenbrander <redacted>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help