Re: [PATCH v3 4/4] input: serio: Replace timeval by timespec64

From
Deepa Dinamani <hidden>
Date
2017-12-04 20:37:46
Also in
lkml
Reply to
Arnd Bergmann, 2017-12-04
On Mon, Dec 4, 2017 at 5:44 AM, Arnd Bergmann [off-list ref] wrote:
On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani [off-list ref] wrote:
quoted
struct timeval is not y2038 safe.
All references to timeval will be deleted from the
kernel to make it y2038 safe.
Replace its uses by y2038 safe struct timespec64.

The timestamps changed here only keep track of delta
times. These timestamps are also internal to kernel.
Hence, monotonic times are sufficient here.
The unit of the delta times is also changed in certain
cases to nanoseconds rather than microseconds. This is
in line with timespec64 which keeps time in nanoseconds.

Signed-off-by: Deepa Dinamani <redacted>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Hi Deepa,

I forgot you also had these on your backlog. I submitted a different
set of patches
two weeks ago for the two HP drivers, originally by Pingbo Wen, based on a
different approach.

That version simplified the code in question a bit more by using jiffies,
while your version is a little safer since it changes less. Both versions
should be fine though, it's up to Dmitry which one he wants to pick up.
Dmitry, please let me know if you would like this version. If not, I
can drop the patch when I post an update.

-Deepa
Thread (16 messages) 16 messages, 3 authors, last reply 2017-12-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help