Thread (10 messages) 10 messages, 3 authors, 2017-11-27
STALE3109d

[PATCH 1/3] input: remove redundant check for EV_REP

From: Sean Young <sean@mess.org>
Date: 2017-11-24 11:44:04
Also in: linux-media
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

The caller input_pass_values has already checked this bit.

Signed-off-by: Sean Young <sean@mess.org>
---
 drivers/input/input.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 762bfb9487dc..ecc41d65b82a 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -74,9 +74,7 @@ static int input_defuzz_abs_event(int value, int old_val, int fuzz)
 
 static void input_start_autorepeat(struct input_dev *dev, int code)
 {
-	if (test_bit(EV_REP, dev->evbit) &&
-	    dev->rep[REP_PERIOD] && dev->rep[REP_DELAY] &&
-	    dev->timer.data) {
+	if (dev->rep[REP_PERIOD] && dev->rep[REP_DELAY] && dev->timer.data) {
 		dev->repeat_key = code;
 		mod_timer(&dev->timer,
 			  jiffies + msecs_to_jiffies(dev->rep[REP_DELAY]));
-- 
2.14.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help