Re: [PATCH 2/3 v2] Input: twl4030_keypad: Fix platform_get_irq's error checking
From: Russell King - ARM Linux <linux@armlinux.org.uk>
Date: 2017-11-18 08:21:45
Also in:
linux-arm-kernel, lkml
On Sat, Nov 18, 2017 at 02:28:49AM +0530, Arvind Yadav wrote:
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.
IRQ 0 is not a valid interrupt. The correct test here is <= 0. Please rework your patches for this. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up