Thread (6 messages) flat view 6 messages, 2 authors, 2017-11-08

Re: [PATCH v2 1/3] Input: ad7897 - use managed allocated resources

From: Andi Shyti <hidden>
Date: 2017-11-08 15:36:31
Also in: lkml

quoted
-	ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL);
-	input_dev = input_allocate_device();
-	if (!ts || !input_dev) {
-		err = -ENOMEM;
-		goto err_free_mem;
-	}
+	ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
+	input_dev = devm_input_allocate_device(&spi->dev);
+	if (!input_dev)
You removed the check for 'ts' here and only added it back in patch 3.
Oh yes, because I squashed the 5 patches I sent earlier and I
forgot about this.

Thanks!

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help