Thread (8 messages) 8 messages, 4 authors, 2017-10-25

Re: [PATCH v2 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-10-25 16:14:43

On Wed, Oct 25, 2017 at 09:31:55AM +0200, Benjamin Tissoires wrote:
On Oct 24 2017 or thereabouts, Andrew Duggan wrote:
quoted
Hi Dmitry,

On 10/24/2017 11:19 AM, Dmitry Torokhov wrote:
quoted
On Tue, Oct 10, 2017 at 09:04:20PM +0300, Yiannis Marangos wrote:
quoted
Hi guys,

As I understand the second part of the patchset will take a while until it get
merged. Is it possible to merge the first part only? Without this, LEN0073 users
can not use psmouse.synaptics_intertouch=1 as a workaround. LEN0073 is not
usable at all unless users patch the kernel manually.
Benjamin, Andrew, any comments/objections on expanding the acceptable
version range?
I didn't comment earlier since I didn't have any specific info about SMBus
v3. But, looking at the spec for v3 it sounds like our v2 touchpads should
be compatible with a v3 bus.

"This version of the specification is a superset of previous versions, 1.0,
1.1, and 2.0. The intent is that all devices compliant with these previous
versions are compliant with this version."

From http://smbus.org/specs/SMBus_3_0_20141220.pdf pg 8 section 1.3.

Based on that quote and the fact that it seems to work for Yiannis makes me
think that this change is probably ok.
I concur. I thought the version was Synaptics' one, but if it is the
SMBus protocol they are following, allowing v3 is OK.

Aceked-By: Benjamin Tissoires [off-list ref]
OK, great.

Yiannis, I need your signed-off-by, it is missing from the patch.

Thanks!

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help