Hi Masaki Ota,

Thanks!

On 11.09.2017 04:38, Masaki Ota wrote:

Hi, Juanito,

In my information, ALPS Touchpad is used on Thinkpad E series and L series.
I don't know the device that is ALPS Touchpad + other vendor TrackStick.
But Lenovo might use ALPS Touchpad on such a combination.

Well, that is probably my fault, as it is not the original touchpad that
was delievered with the laptop. I bought the touchpad (that included
the three buttons) separately because I didn't like the clickpad that
came with my laptop.

And I have found that the V7 protocol device has a special ID for Lenovo.
ALPS assigns the value that is the model type to 0xC399 address.

Could you check 0xC399 address value such like a below code?
reg_val = alps_command_mode_read_reg(psmouse, 0xC399);

If the value is 0x1 or 0x2 or 0x6 or 0x10 or 0xF, it has a Stick buttons.

I will check this as soon as I can (I don't have access to the laptop
right now).

Best Regards,
Masaki Ota
-----Original Message-----
From: Juanito [mailto:juam+kernel@posteo.net] 
Sent: Sunday, September 10, 2017 3:22 AM
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>; Pali Rohár <redacted>
Cc: 太田 真喜 Masaki Ota <redacted>; linux-input@vger.kernel.org; Paul Donohue <redacted>
Subject: Re: ALPS touchpad ot correctly recognized: GlidePoint vs DualPoint

On 09/09/2017 08:12 PM, Dmitry Torokhov wrote:

quoted

On Sat, Sep 09, 2017 at 10:36:06AM +0200, Pali Rohár wrote:

quoted

On Saturday 09 September 2017 10:12:42 Juanito wrote:

quoted

Hello,

On 09/08/2017 08:48 AM, Pali Rohár wrote:

quoted

On Friday 08 September 2017 07:00:34 Juanito wrote:

quoted

quoted

ThinkPad with ALPS? Should not be it Synaptic? Maybe 
miss-detection?

Sorry, I forgot to mention this. The ThinkPad came with a clickpad 
I **really** disliked, so I bought this on the Internet.

So, here is a problem. ThinkPads works with Synaptic touchpads, not 
with ALPS.

There definitely seems to be a problem here :)

Do you mean that the alps code might not be detecting the trackpoint 
because probably the red thingie works with synaptics?

So could this be the situation:
ALPS driver: Hey touchpad! Do you have a trackstick?
ALPS touchpad: No, I don't.
AD: Ok! (and thinks 'I am going to have to ignore all trackstick 
packets that might arrive')

So the driver understands that there can't possibly be any buttons 
because there is no trackstick?

IIRC ALPS touchpad hardware itself does not work with non-ALPS 
trackpoint.

Masaki, any comments?

quoted

quoted

quoted

If by trackstick you mean the red thingie, it is **not** working.

Ok. And it is working with your patch?

No, it isn't :(

I expected... You just created franken-hardware.

Looks like with your hack patch it is possible to make buttons 
working, but I suspect that trackstick would.

Maybe Masaki can provide more information about this fact if we can 
do anything.

Dmitry, what you as maintainer going to do with this problem?

It really depends on Ota-san response. If ALPS needs a special version 
of firmware flashed for proper trackstick identification, then I guess 
Juanito will have to carry a local patch. I do not think we want to 
complicate the driver any further for supporting such after-market 
modification.

If this only happens in this after-market (or franken-hardware...
hahaha), I'd totally understand if you didn't want to patch it upstream, although it would be nice for me :)

quoted

Does booting with psmouse.proto=imps makes trackstick work?

I am afraid I can't test it now as I don't have access to the laptop. I won't be able to test until two weeks. Will definitely do as soon as I can.

quoted

Thanks.

Thank **you** (Dmitry and everybody esle) for taking the time to look at this.

Juanito

Thank you very much!

Best regards,
Juanito