Thread (15 messages) 15 messages, 4 authors, 2017-09-21

Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Date: 2017-09-21 14:18:07
Also in: dri-devel, linux-i2c, linux-iio, linux-media, linux-renesas-soc, lkml

On Wed, 20 Sep 2017 20:59:56 +0200
Wolfram Sang [off-list ref] wrote:
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Makes sense as do the other drivers.

Feel free to add

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

to all of them (though they hardly took a lot of reviewing given how simple
the patches were :)
quoted hunk ↗ jump to hunk
---
 drivers/i2c/i2c-dev.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index 6f638bbc922db4..bbc7aadb4c899d 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -280,6 +280,8 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client,
 			res = PTR_ERR(rdwr_pa[i].buf);
 			break;
 		}
+		/* memdup_user allocates with GFP_KERNEL, so DMA is ok */
+		rdwr_pa[i].flags |= I2C_M_DMA_SAFE;
 
 		/*
 		 * If the message length is received from the slave (similar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help