Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case
From: Jiri Kosina <jikos@kernel.org>
Date: 2017-09-13 14:52:26
Also in:
lkml
From: Jiri Kosina <jikos@kernel.org>
Date: 2017-09-13 14:52:26
Also in:
lkml
On Wed, 13 Sep 2017, Dmitry Torokhov wrote:
quoted
quoted
From: Adrian Salido <redacted> The buffer allocation is not currently accounting for an extra byte for the report id. This can cause an out of bounds access in function i2c_hid_set_or_send_report() with reportID > 15. Signed-off-by: Guenter Roeck <groeck@chromium.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>Missing signoff from the patch author?Oops, I must have cut it off on accident while removing ChromeOS specific tags, the original commit is here: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212
Ok, thanks, will use that one. How about Reviewed-by: Benson Leung [off-list ref] which is missing in the mail you've sent, but is there in the above reference commit?
quoted
Also, I think this should have Cc: stable, right?I usually let maintainers decide, but yes.
I'll be adding it. Thanks, -- Jiri Kosina SUSE Labs