Re: [PATCH 1/2] Input: tegra-kbc: Handle return value of clk_prepare_enable.

From
Dmitry Torokhov <hidden>
Date
2017-08-31 18:51:11
Also in
linux-tegra, lkml
Reply to
Arvind Yadav, 2017-08-01
On Tue, Aug 01, 2017 at 03:32:26PM +0530, Arvind Yadav wrote:
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
---
 drivers/input/keyboard/tegra-kbc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 0c07e10..edc1385 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -370,8 +370,11 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
 {
 	unsigned int debounce_cnt;
 	u32 val = 0;
+	int ret;
 
-	clk_prepare_enable(kbc->clk);
+	ret = clk_prepare_enable(kbc->clk);
+	if (ret)
+		return ret;
 
 	/* Reset the KBC controller to clear all previous status.*/
 	reset_control_assert(kbc->rst);
-- 
1.9.1
-- 
Dmitry
Thread (4 messages) 4 messages, 2 authors, last reply 2017-08-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help