Re: [PATCHv4 1/3] dt-bindings: input: add pwm-vibrator
From: Pavel Machek <hidden>
Date: 2017-07-24 19:21:00
Also in:
linux-devicetree, linux-omap, lkml
On Fri 2017-07-14 12:01:49, Sebastian Reichel wrote:
Add DT binding document for PWM controlled vibrator devices. Signed-off-by: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Acked-by: Pavel Machek <redacted>
quoted hunk ↗ jump to hunk
index 000000000000..09145d18491d--- /dev/null +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt@@ -0,0 +1,66 @@ +* PWM vibrator device tree bindings + +Registers a PWM device as vibrator. It is expected, that the vibrator's +strength increases based on the duty cycle of the enable PWM channel +(100% duty cycle meaning strongest vibration, 0% meaning no vibration). + +The binding supports an optional direction PWM channel, that can be +driven at fixed duty cycle. If available this is can be used to increase +the vibration effect of some devices.
Actually what "direction" does would be nice to explain, because I don't know. Does it make the motor turn the other way around?
+Required properties: +- compatible: should contain "pwm-vibrator"
should->Should.
+- pwm-names: Should contain "enable" and optionally "direction" +- pwms: Should contain a PWM handle for each entry in pwm-names + +Optional properties: +- vcc-supply: Phandle for the regulator supplying power +- direction-duty-cycle-ns: Duty cycle of the direction PWM channel in + nanoseconds, defaults to 50% of the channel's + period.
Is nanoseconds right unit here? It drives a motor... Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 181 bytes