Thread (4 messages) 4 messages, 3 authors, 2017-07-20

Re: [PATCH] HID: hid-logitech-hidpp: add NULL check on devm_kmemdup() return value

From: Jiri Kosina <jikos@kernel.org>
Date: 2017-07-20 13:46:22
Also in: lkml

On Fri, 7 Jul 2017, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
Check return value from call to devm_kmemdup()
in order to prevent a NULL pointer dereference.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/hid/hid-logitech-hidpp.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 41b3946..501e16a 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -2732,6 +2732,9 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp)
 				     hidpp_battery_props,
 				     sizeof(hidpp_battery_props),
 				     GFP_KERNEL);
+	if (!battery_props)
+		return -ENOMEM;
+
Applied to for-4.13/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help