[PATCH] input: tegra-kbc: add NULL check on of_match_device() return value
From: Gustavo A. R. Silva <hidden>
Date: 2017-07-07 06:28:03
Also in:
linux-tegra, lkml
Subsystem:
input (keyboard, mouse, joystick, touchscreen) drivers, tegra kbc driver, the rest · Maintainers:
Dmitry Torokhov, Laxman Dewangan, Linus Torvalds
Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by: Gustavo A. R. Silva <redacted> --- drivers/input/keyboard/tegra-kbc.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 0c07e10..742c5ac 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c@@ -617,6 +617,10 @@ static int tegra_kbc_probe(struct platform_device *pdev) const struct of_device_id *match; match = of_match_device(tegra_kbc_of_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "failed to match device\n"); + return -ENODEV; + } kbc = devm_kzalloc(&pdev->dev, sizeof(*kbc), GFP_KERNEL); if (!kbc) {
--
2.5.0