Thread (6 messages) 6 messages, 3 authors, 2017-07-11

Re: [PATCH] Input: joydev - ignore accelerometer devices

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-06-20 02:57:13

On Mon, Jun 12, 2017 at 09:09:53AM +0200, Benjamin Tissoires wrote:
On Jun 09 2017 or thereabouts, Roderick Colenbrander wrote:
quoted
From: Roderick Colenbrander <roderick.colenbrander@sony.com>

Gamepads like DualShock 3 / 4 as of 4.12 started reporting motion
sensors on a separate evdev node. Joydev is picking these devices
up as well, but they don't make sense for the joydev interface.

Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
---
Acked-By: Benjamin Tissoires <redacted>
Hmm, I think you can quite often use accelerometer as a joystick, it is
only the composite devices that we want to ignore I think.
Cheers,
Benjamin
quoted
 drivers/input/joydev.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
index 29d677c..a5ceaaf 100644
--- a/drivers/input/joydev.c
+++ b/drivers/input/joydev.c
@@ -819,6 +819,10 @@ static bool joydev_match(struct input_handler *handler, struct input_dev *dev)
 	if (joydev_dev_is_absolute_mouse(dev))
 		return false;
 
+	/* Avoid accelerometers */
+	if (test_bit(INPUT_PROP_ACCELEROMETER, dev->propbit))
+		return false;
+
 	return true;
 }
 
-- 
2.9.3
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help