Thread (1 message) 1 message, 1 author, 2017-06-19

Re: [RFC v2 PATCH] Fix modifier keys for Redragon Asura Keyboard

From: Robert Munteanu <hidden>
Date: 2017-06-19 07:33:24

Hi Michel,

On Fri, 2017-06-16 at 08:30 +0200, Michel Hermier wrote:
Are you sure it is the correct way to do it? I mean I looked a little
to
the hid descriptor and it seemed to be correct, at least the part
that
describe key modifiers. So it smell more like a hid parser bug,
forgetting
to consume/declare one byte before the modifiers bits.
I am not sure about the correctness of the approach, thus the RFC :-)

It was also quite easy for me to discover the behaviour when using a
new module, but with the existing code base I find it harder to
navigate.

Can you point me to where the hid codes are parsed? Is it
hidinput_setkeycode in hid-input.c?

Thanks,

Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help