Thread (11 messages) 11 messages, 3 authors, 2017-07-22

[PATCHv4 1/4] mfd: da9052: fix manual ADC read after timed out read

From: Sebastian Reichel <hidden>
Date: 2017-06-30 14:35:20
Also in: linux-devicetree, linux-hwmon, lkml
Subsystem: dialog semiconductor drivers, multifunction devices (mfd), the rest · Maintainers: Support Opensource, Lee Jones, Linus Torvalds

It is possible that under heavy system load, the counter in the completion
struct, used for waiting for end of AD conversion, gets incremented twice.
To make sure the driver recovers from this situation, the completion struct
should be reinitialized.

Signed-off-by: Sebastian Reichel <redacted>
---
 drivers/mfd/da9052-core.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/da9052-core.c b/drivers/mfd/da9052-core.c
index a88c2065d8ab..977418ca9117 100644
--- a/drivers/mfd/da9052-core.c
+++ b/drivers/mfd/da9052-core.c
@@ -386,6 +386,8 @@ int da9052_adc_manual_read(struct da9052 *da9052, unsigned char channel)
 
 	mutex_lock(&da9052->auxadc_lock);
 
+	reinit_completion(&da9052->done);
+
 	/* Channel gets activated on enabling the Conversion bit */
 	mux_sel = chan_mux[channel] | DA9052_ADC_MAN_MAN_CONV;
 
-- 
2.11.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help