Re: [PATCH v2] HID: Replace semaphore driver_lock with mutex

Hi,

On 13 June 2017 at 15:26, Benjamin Tissoires
[off-list ref] wrote:

quoted

Looks good to me, but I see you didn't include David and Andrew on
Cc, it would be good for at least one of them to provide an Ack as well.

Please also CC linux-input@

Will do that.

(one more nitpick below too)
A little bit below, there is:
        bool io_started;                                                /* Protected by driver_lock. If IO has started */

You should probably remove the mention to driver_lock here.

Will remove the reference too.

quoted

quoted

-       struct semaphore driver_lock;                                   /* protects the current driver, except during input */
+       struct mutex driver_lock;                                       /* protects the current driver, except during input */
        struct semaphore driver_input_lock;                             /* protects the current driver */

Unless I am mistaken, this one could also be converted to a mutex (in a
separate patch, of course).

Thank you for noticing that, initially I missed it as I thought
'io_started' somehow
influences the increment of the semaphore, but its anyway used only in
hid-core.c

Thanks,
Binoy