Thread (5 messages) flat view 5 messages, 2 authors, 2017-06-08

Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1

From: Benjamin Tissoires <hidden>
Date: 2017-06-08 07:29:31
Also in: lkml

On Jun 08 2017 or thereabouts, Philipp Zabel wrote:
Hi Benjamin,

On Wed, Jun 7, 2017 at 9:11 AM, Benjamin Tissoires
[off-list ref] wrote:
quoted
Hi Philip,

On Jun 07 2017 or thereabouts, Philipp Zabel wrote:
[...]
quoted
2 things:
- the 2 patches should be squashed together. There is no point having a
  single patch for just 2 defines not used anywhere else.
- I believe you don't even need this quirk in the development version of
  the hid tree. Would you mind trying a plain v4.12-rcX and report if
  you still need the quirk?
Thanks, you are right. I just checked on v4.12-rc4 and now it works without
the quirk. Sorry for the noise.
No worries. It's always interesting to know that we introduced a patch
that actually fixes hardware :)

So thanks for the report and the attempt :)

Cheers,
Benjamin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help