Re: Missing release event for Synaptics touchscreen
From: Arek Burdach <hidden>
Date: 2017-05-15 18:49:03
From: Arek Burdach <hidden>
Date: 2017-05-15 18:49:03
Hi Benjamin, I found out what was wrong in the change that you've provided: On 12.05.2017 16:28, Benjamin Tissoires wrote: >> >> + if (td->mtclass.quirks & MT_QUIRK_STICKY_FINGERS) + mod_timer(&td->release_timer, msecs_to_jiffies(250)); } Should be: mod_timer(&td->release_timer, jiffies + msecs_to_jiffies(100)); Delay should be added to current jiffies value. Also I found out that 250 ms is too long delay - xserver recognize such a delay as a drag gesture. Using 100 ms everything works perfectly! What do you think that should be changed more in the patch to make it ready for being submitted as an official patch? I thought about some unit tests, but can't find any for hid drivers also I don't know how to mock timers. One more time, thank you for your support! Cheers, Arek