Re: [PATCHv2] Input: xpad - sync supported devices with 360Controller
flat view
From: Benjamin Valentin <benpicco@googlemail.com>
Date: 2017-05-11 22:22:46
On Mon, 8 May 2017 22:18:49 -0700 Cameron Gutman [off-list ref] wrote:
It looks like you dropped a few entries from xpad_table[]. With that table, I'd rather just list the VIDs and risk a chance it's wrong and doesn't work than not list it and guarantee 100% that it won't work. If the interface descriptor doesn't look right to us, we won't touch it anyway.
Well I'm not so sure about how valid they were. 0810:0003 Trust Predator actually seems to be a PlayStation Gamepad/Adapter according to the USB ID Repository. [0] Game-Debate [1] confirms this. 11c0:5506 BETOP GAMEFORWINDOWS is most likely BTP-2175 [2] which can also switch to DirectInput/HID mode (?) where it aleady works out of the box with Linux [3] so this might possibly break things. Or enable things as I'm not sure if the HID driver supports the rumble functionality. 360Controller detects it as Xbox 360 Controller on OS X [4] with this ID, so it might actually be a good idea to add it back.
I also have a few name nits to throw in your respin.
I will address those in v3 [0] https://usb-ids.gowdy.us/read/UD/0810/0003 [1] http://www.game-debate.com/gamepad/index.php?ga_id=41&gamepad=Trust%20Predator [2] https://www.banggood.com/de/Betop-BTP-2175-Asura-Double-Vibration-Computer-Game-Controller-p-1063903.html [3] http://unsolicitedbutoffered.blogspot.de/2017/04/tested-betop-controller-with-fedora-25.html [4] http://unsolicitedbutoffered.blogspot.de/2017/05/tested-betop-controller-openemu_7.html