Re: [PATCH v2 4/5] HID: intel_ish-hid: fix format string for size_t
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2017-05-22 23:46:47
Also in:
lkml
On Thu, 2017-05-18 at 22:21 +0200, Arnd Bergmann wrote:
When building for 32-bit architectures, we get a harmless warning: intel-ish-hid/ishtp-hid-client.c: In function 'process_recv': intel-ish-hid/ishtp-hid-client.c:139:7: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format=] This changes the format string to print size_t variables using %zu instead.
Is the ordering of patch correct? ISH config depends on X86_64, so it would not be enabled for 32 bit build. So your patch 5/5 will adding "|| COMPILE_TEST", hence it is building. Thanks, Srinivas
quoted hunk ↗ jump to hunk
Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.cb/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 5c643d7a07b2..157b44aacdff 100644--- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c@@ -136,10 +136,9 @@ static void process_recv(struct ishtp_cl*hid_ishtp_cl, void *recv_buf, if (1 + sizeof(struct device_info) * i >= payload_len) { dev_err(&client_data-quoted
cl_device->dev,- "[hid-ish]: [ENUM_DEVICES]: content size %lu is bigger than payload_len %u\n", + "[hid-ish]: [ENUM_DEVICES]: content size %zu is bigger than payload_len %zu\n", 1 + sizeof(struct device_info) - * i, - (unsigned int)payload_len); + * i, payload_len); } if (1 + sizeof(struct device_info) * i >=